Update dashboard #104
Merged
Update dashboard #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoxhaa
force-pushed
the
update-dashboard
branch
5 times, most recently
from
9f1c313 to
554d298
Compare
jhoxhaa
force-pushed
the
update-dashboard
branch
from
554d298 to
f2aeda8
Compare
jhoxhaa
force-pushed
the
multi-cluster
branch
from
201af4d to
8075044
Compare
jhoxhaa
force-pushed
the
update-dashboard
branch
2 times, most recently
from
21db026 to
0a1547d
Compare
jhoxhaa
force-pushed
the
update-dashboard
branch
3 times, most recently
from
2b223d2 to
6aa37b4
Compare
lippserd
requested changes
Dec 18, 2024
|
|
||
| class DashboardController extends Controller | ||
| { | ||
| public function indexAction() |
| $this->addTitleTab($this->translate('Kubernetes')); | ||
|
|
||
| $cluster = (new ClusterForm()) | ||
| ->populate(['cluster_uuid' => Session::getSession()->getNamespace('kubernetes')->get('cluster_uuid')]) |
There was a problem hiding this comment.
Default in the get() call should be ClusterForm::ALL_CLUSTERS.
| ); | ||
| } | ||
|
|
||
| protected function isMultiCluster() |
| return $this->translate('Cluster management'); | ||
| } | ||
|
|
||
| protected function assemble() |
| 'node', | ||
| $this->translate('Nodes'), | ||
| $this->translate( | ||
| 'Out of %s total Nodes, %s are in OK state, %s are Critical, %s are in Warning state, and |
There was a problem hiding this comment.
Don't use %s, but {total} and so on.
| return $this->translate('Observability'); | ||
| } | ||
|
|
||
| protected function assemble() |
| return $this->translate('Storage'); | ||
| } | ||
|
|
||
| protected function assemble() |
| ->columns(['uuid', 'name']); | ||
|
|
||
| foreach ($clusters as $cluster) { | ||
| yield (string) Uuid::fromBytes($cluster->uuid) => $cluster->name; |
There was a problem hiding this comment.
You could do $cluster->name ?? $cluster->uuid here and don't do it in assemble().
library/Kubernetes/Web/Factory.php
Outdated
| @@ -138,7 +139,32 @@ public static function createList(string $kind, Rule $filter): ValidHtml | |||
| } | |||
| } | |||
|
|
|||
| public static function createUrl(string $kind): ?Url | |||
| public static function createModel(string $kind): Model | |||
There was a problem hiding this comment.
Should be ?Model as it may also return null.
| } | ||
| } | ||
|
|
||
| .control-label-group { |
There was a problem hiding this comment.
Put those rules inside .cluster-form and add the class to ClusterForm.
jhoxhaa
force-pushed
the
update-dashboard
branch
from
6aa37b4 to
d349306
Compare
jhoxhaa
force-pushed
the
update-dashboard
branch
from
d349306 to
2d28cc0
Compare
lippserd
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.